[Libre-soc-bugs] [Bug 1157] Implement poly1305

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Wed Oct 11 21:08:55 BST 2023


--- Comment #28 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Sadoon Albader from comment #27)
> This is a copy-pasta of poly1305-donna.py

as a general rule that is not done. it results in a hell of a
maintenance headache if a bug is found in *one* of the *copies*
of the duplicated code.

also i cannot review the diff because it isn't a diff!

i.e. you made *two* changes - two actions - and merged them 
into one commit.

1. you copied the file AND
2. you made changes to the file.

(the clue being the word "AND", this is not allowed
 under the HDL_workflow development practices)

please the simulator() function to the original file.
(and remove this one. two separate commits please)

also you missed adding yourself as a Copyright holder.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list