[Libre-soc-bugs] [Bug 1039] add hardware-cycle-accurate stastistical modelling to ISACaller for an in-order core

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Tue May 16 02:22:12 BST 2023


--- Comment #15 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Dmitry Selyutin from comment #11)

> Jacob, Luke, I've re-checked the discussion[0][1], and came to conclusion
> that you both have valid points, so I decided to go with something
> intermediate. The branch tracefile contains the following functionality:

there should be no branch.  it is unnecessary.

> 1. Every ISACaller instance can be provided with `tracefile` argument; this
> argument must be any object which has a callable `write` attribute or None.


> 2. If `ISACaller.tracefile` is None, then we create a temporary file.

*NO*.  please do not do this.  there is no such requirement.

> 3. However, we don't save these temporary files, unless TRACEFILE
> environment variable is set to anything. By default, these files are
> __transient__.


> 4. If and only if the user sets TRACEFILE environment variable, the
> tracefiles are kept.


> 5. The files have names starting with "trace_" and ending with ".trace".


> Everything inbetween obeys tempfile.NamedTemporaryFile rules.


> 6. test_runner has extended names, starting with either "trace_testXX_" or
> "trace_subtestXX_", where XX stands for global test counter (if launched via
> run_tst) or for test_case unique counter (nmutil.get_test_path.Counter).
> Everything inbetween obeys tempfile.NamedTemporaryFile rules.

complete overkill.

> This way:
> 1. We avoid conditional code which checks whether `self.tracefile` is None
> or not.

there is no requirement to create temporary tracefiles.  if there was
such a requirement i would have mentioned it.

the requirement was added by jacob who is not the project manager.

this task is drastically and brutally simple.  it is being made or is
envisioned to be far more complex than it actually is or needs to be.

absolute bare minimum and extreme simplicity is required - no error-checking
is required (at all) because the output from ISACaller is completely
under our control and is intended as machine-readable input of the absolute
simplest format and level.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list