[Libre-soc-bugs] [Bug 1072] implement fcvt/fmv instructions in ISACaller (ls006)

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu May 4 05:52:32 BST 2023


https://bugs.libre-soc.org/show_bug.cgi?id=1072

--- Comment #4 from Jacob Lifshay <programmerjake at gmail.com> ---
I added all the pseudo-code and fields.txt stuff, will add unit tests next.

while doing that, I got fed up with the terrible pseudo-code syntax error
reports and fixed that to use Python's normal location reporting, which has the
added benefit that IDEs understand that error format and can go straight to the
syntax error in the file.
errors now look like:
  File
"/home/jacob/projects/libreriscv/openpower-isa/src/openpower/decoder/pseudo/parser.py",
line 873, in p_error
    self.input_text)
  File
"/home/jacob/projects/libreriscv/openpower-isa/src/openpower/decoder/pseudo/lexer.py",
line 21, in raise_syntax_error
    input_text[line_start:line_end]))
  File
"/home/jacob/projects/libreriscv/openpower-isa/openpower/isa/condition.mdwn",
line 119
    CR[BT+32] <- CR[BA+32] |  ¬CR[BB+32] ERROR HERE
                                         ^
SyntaxError: LexToken(NAME,'ERROR',119,155)
make: *** [Makefile:18: pywriter] Error 1


https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=2aa59d113549e4e7582b6d9b4d8ddcd09d63164c

commit 2aa59d113549e4e7582b6d9b4d8ddcd09d63164c
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 21:41:31 2023 -0700

    fix forgotten stuff from last commit

commit 9255849db0fa7b5aa703d1bde0ee7257579ffb21
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 21:27:06 2023 -0700

    add fcvt/fmv -- no tests yet

commit 3cdf23bcd2851ba8683e6782856398b98e4aded5
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 21:25:42 2023 -0700

    support calling functions with no args in pseudocode

commit 8e0f6ea81295acbf72a14d8310fb3cd48ba01ba5
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 21:15:45 2023 -0700

    show actual mdwn source location in backtrace when parser raises
SyntaxError

commit 10ba7151784dc708837c55d92528d7c3ca022920
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 21:08:49 2023 -0700

    move Assign to parser class in prep for improving syntax error reporting

commit 9c588688ac2b354986062fb275c329db4eeb4db1
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 18:55:29 2023 -0700

    add all fmv*/fcvt* fields

commit e0160c09fd084659a64ad591f2202055c43fbde4
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 3 18:48:46 2023 -0700

    split XO-Form's RA field in prep for adding fcvttg[o][s]

    also reformat cuz we can

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list