[Libre-soc-bugs] [Bug 1094] insndb instruction database visitor-walker is needed

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Tue Jun 20 20:11:36 BST 2023


--- Comment #211 from Dmitry Selyutin <ghostmansd at gmail.com> ---
(In reply to Jacob Lifshay from comment #210)
> (In reply to Dmitry Selyutin from comment #209)
> imho this or the one returning objects with node, parent, and path fields is
> good. I do think we should pick whichever option is faster, since the walker
> is likely hot code.

I think yielding a tuple would be better then. Plus I kinda dislike the
wrapping here, though cannot clearly formulate why (even for myself).

Also, on paths. If we yield the parent (which I assumed is the original
instance), perhaps the path should point to this parent, and not to the root?
We currently keep the whole path.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list