[Libre-soc-bugs] [Bug 1094] insndb instruction database visitor-walker is needed

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Tue Jun 20 20:07:04 BST 2023


--- Comment #210 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Dmitry Selyutin from comment #209)
> Does it meet your expectations? As you see I chose {} for hashes and pass
> the stuff which was used.

lgtm, though imho Hash is a misnomer, maybe name it GetKey?

> for (node, parent, path) in walker(items):

imho this or the one returning objects with node, parent, and path fields is
good. I do think we should pick whichever option is faster, since the walker is
likely hot code. if we can guarantee callers won't keep the returned object
around, the fastest would probably to return the same object every time and
just update its node, etc. fields.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list