[Libre-soc-bugs] [Bug 899] implement additional Transcendentals in simulator

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=899

--- Comment #24 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
not if the unit test computes the expected value another way using
a subroutine or math library.

direct explicit precomputed values like this are useless for
understanding and manual doublechecking.

please look at the style used in the dct and fft tests
which have actual routines (understandable ones, from
project nayuki) computing the expected values.

i have no problem with non-exact values at this early
stage, i.e  doing the usual subtract abs less-than-tiny-value
more accuracy can be added later

iirc the comparison on dct is to 1e-6, it's such a huge
accumulated error.

it's fine as things stand, we need to move on, but do give
some thought to that, esp. if it's quick to fix.  and also
gives the possibility of checking a few more values.

if it's a lot of work let's move on and plan improvements
later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.