[Libre-soc-dev] daily kan-ban update 07nov2020

[Luke Kenneth Casson Leighton]

On Sat, Nov 7, 2020 at 2:48 PM Tobias Platen
<libre-soc at platen-software.de> wrote:
>
> today: fixed a bug in src/soc/fu/mmu/fsm.py

thank you tobias.  for future could you provide a brief description of
what was done?  in this case, "fixed bug where switch was using op not
op.insn_type".

it still fits on one line.  if the git log is full of "fixed bug" and
"added this" and "added that" it is impossible to find things
retrospectively when the need arises (and it definitely does).

l.


@@ -88,9 +94,12 @@ class FSMMMUStage(ControlBase):
             # should "action" the operation.  one of MMU or DCache gets
             # enabled ("valid") and we twiddle our thumbs until it
             # responds ("done").
-            with m.Switch(op):
-
+            with m.Switch(op.insn_type):
                 with m.Case(MicrOp.OP_MTSPR):

---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68

> --
> Tobias Platen <libre-soc[at]platen-software[dot]de>
>
> _______________________________________________
> Libre-soc-dev mailing list
> Libre-soc-dev at lists.libre-soc.org
> http://lists.libre-soc.org/mailman/listinfo/libre-soc-dev