[Libre-soc-bugs] [Bug 1173] provide an option to switch ISACaller to use a different Mem class that uses mmap.mmap instead of a dict

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Tue Oct 24 20:51:00 BST 2023


Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
             Blocks|                            |983
             Status|RESOLVED                    |IN_PROGRESS
         Resolution|FIXED                       |---

--- Comment #15 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #14)

>     def add_case(self, all, the, current, args, *, src_loc_at=0, **kwargs):
>         args = {
>             "all": all,
>             "the": the,
>             "current": current,
>             "args": args,
>             **kwargs
>         }
>         for k in args.keys() | self.defaults.keys():

needs to be the other way round

          for k in self.defaults.keys() | args.keys():

so that if the *test case* argument is supplied, it actually
gets supplied.

the way you wrote it, there is no way to "override" a default.

Referenced Bugs:

[Bug 983] Support PowerPC SFFS compliance
You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list