[Libre-soc-bugs] [Bug 1195] New: removing some f-strings and misleading log messages

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Sat Oct 21 00:07:37 BST 2023


            Bug ID: 1195
           Summary: removing some f-strings and misleading log messages
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: IN_PROGRESS
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: programmerjake at gmail.com
          Reporter: programmerjake at gmail.com
                CC: libre-soc-bugs at lists.libre-soc.org, lkcl at lkcl.net,
                    programmerjake at gmail.com
   NLnet milestone: ---

At luke's request, I rewrote the f-strings and str.format() calls in some files
to use printf-style formatting, pushing the changes to
the programmerjake/remove-f-strings branch:


commit f75d15aeaa4e321462d0e19a19e075c48ee38691
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Fri Oct 20 15:32:27 2023 -0700

    replace some f-strings and str.format calls with % as luke requested

I also changed the code to not generate log messages like the following:

setting spr TFHAR SelectableInt(value=0x0, bits=64)
setting spr TFIAR SelectableInt(value=0x0, bits=64)
setting spr TEXASR SelectableInt(value=0x0, bits=64)
setting spr TEXASRU SelectableInt(value=0x0, bits=32)

it turns out they were generated by the code that checks if all SPRs match
ExpectedState running caller.SPR.__getitem__, which calls __setitem__ for SPRs
it doesn't have entries for:

commit 6521a032629e493db091860c690b3487ea142a6c
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Fri Oct 20 16:00:41 2023 -0700

    don't generate misleading log messages setting unimplemented SPRs to zero

    turns out they're generated by calling caller.SPR.__getitem__

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list