[Libre-soc-bugs] [Bug 1193] TrapTestCase.case_2_rfid is broken, without an obvious fix

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Fri Oct 20 03:39:18 BST 2023


Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
    NLnet milestone|---                         |Future
           See Also|                            |https://bugs.libre-soc.org/
                   |                            |show_bug.cgi?id=859

--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #2)

> yes, but in order for pytest/CI to properly test sc,

why are you using pytest in a mode that does not run all tests?
what is the point of that?

>  the other cases in the
> same class need to pass, otherwise they stop the test early and later cases
> don't get run. This is because pytest treats the whole class as a unit.

then fix that in the CI so that they are all run!

whenever i run python3 test_caller_trap.py it runs everything.

therefore there is something wrong with how you have set up CI,
which needs fixing, not skipping the test case.

> ok, well in that case, microwatt is just wrong, since it's in privileged
> mode, not problem mode (unless reserved MSR bits 1:2 are causing the trap).
> I'll revert that skip_case commit.

thank you.

(In reply to Jacob Lifshay from comment #3)

> the commit message where the expected state for case_2_rfid was added makes
> me think you added whatever made the soc tests happy at the time, rather
> than what matched microwatt:
> https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;
> h=cf8eaed82a022f2de46e8a4a358b211aefddb0d7
> this is when you were working on
> https://bugs.libre-soc.org/show_bug.cgi?id=859
> microwatt's privileged tests do give pc=0x700, but only because they set
> Problem state and try to run rfid, which traps because it is privileged.

sigh this sounds right. it was much too long ago to remember.

okaaay it needs to go on the increasingly-long list of additional
future work to get better unit tests.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list