[Libre-soc-bugs] [Bug 1072] implement fcvt/fmv instructions in ISACaller (ls006)

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1072

--- Comment #16 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
please put that back.

@@ -1250,7 +1250,6 @@ class ISACaller(ISACallerHelper, ISAFPHelpers, StepLoop):
                                'FPSCR': self.fpscr,
                                'undefined': undefined,
                                'mode_is_64bit': True,
-                               'SO': XER_bits['SO'],
                                'XLEN': 64  # elwidth overrides
                                })
comment 12. both of these should not be necessary, ISACaller
derives from ISACallerHelper.

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=7a34ff20acf34834c7878fecff574d844ba8a538

it is definitely a bug to have an arbitrary hidden piece of state
created, i.e. not from the constructor.
look where DOUBLE2SINGLE is used in some of the
matrix/fft unit tests.

*really* do not create hidden side-effects, hunting them down
in unknown python code is a total bitch, wastes vast amounts of
time.

it is better to force users of standalone ISACallerHelper to
pass in an initial_fpscr there

and to then make ISACaller initialise it (pass on the initial_fpscr
argument).

otherwise you have two copies of FPSCRState.

-- 
You are receiving this mail because:
You are on the CC list for the bug.