[Libre-soc-bugs] [Bug 1094] insndb instruction database visitor-walker is needed

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Wed Jun 28 23:20:56 BST 2023


--- Comment #238 from Dmitry Selyutin <ghostmansd at gmail.com> ---
After discussion, I've decided to reimplement arguments detection. From now on,
we always expect at least 2 positional arguments: a dispatcher instance and a
node. However, the caller can pass any additional arguments, be it positionals
or keywords. The detection is done via inspect.

Also, the concrete hook now wraps the original function; therefore
ConcreteHook.__call__ refers to the original method we wrapped. Example for
Walker.dispatch_unordered_sequence (irrelevant details snipped):

class ConcreteHook(Hook)
 |  ConcreteHook(*typeids)
 |  Methods defined here:
 |  __call__ = dispatch_unordered_sequence(self, node)


Is it sufficient to mark this task as completed, or we have other ideas?

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list