[Libre-soc-bugs] [Bug 1094] insndb instruction database visitor-walker is needed

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1094

--- Comment #119 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Dmitry Selyutin from comment #118)
> Luke, thank you for your investigation! I'm sorry for missing this ussue,
> felt myself kinda invincible. :-) 

:)

> I've fixed, this is again the same error I
> always do: using isinstance instead of issubclass.

still some work to do:

python3 decoder/isa/test_caller_svp64_fp.py >& /tmp/f

======================================================================
ERROR: test_sv_fpmadds (__main__.DecoderTestCase)
>>> lst = ["sv.fmadds *6, *2, *4, 8"
----------------------------------------------------------------------
Traceback (most recent call last):
  File "decoder/isa/test_caller_svp64_fp.py", line 161, in test_sv_fpmadds
    lst = list(lst)
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/asm.py",
line 61, in __iter__
    yield from self.trans
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/asm.py",
line 114, in translate
    yield from self.translate_one(insn)
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/asm.py",
line 107, in translate_one
    yield from insn.disassemble(record=record, style=Style.LEGACY)
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/core.py",
line 3556, in disassemble
    specifiers = sorted(rm.specifiers(record=record))
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/core.py",
line 3486, in __getattr__
    return getattr(self.rm, key)
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/core.py",
line 3422, in rm
    search = ((mode << 1) | self.record.Rc)
  File "/usr/local/lib/python3.7/dist-packages/cached_property.py", line 36, in
__get__
    value = obj.__dict__[self.func.__name__] = self.func(obj)
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/core.py",
line 1125, in Rc
    return self["Rc"].value
  File "/home/lkcl/src/libresoc/openpower-isa/src/openpower/insndb/core.py",
line 1119, in __getitem__
    return cls(record=self, **kwargs)
TypeError: type object argument after ** must be a mapping, not tuple

-- 
You are receiving this mail because:
You are on the CC list for the bug.