[Libre-soc-bugs] [Bug 1094] insndb instruction database visitor-walker is needed

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Sun Jun 4 15:37:29 BST 2023


--- Comment #40 from Dmitry Selyutin <ghostmansd at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #39)
> ahhh i know what you've missed.  look again at the pyomo Visitor API:

It's not that I missed it, that's a deliberate omission. With context managers,
everything before yield is beforeNode; everything after is afterNode. The way I
currently implemented it is that folks override the manager instead of
overriding three methods. We must choose one approach, either Jacob's or
html-parser-like. Jacob's looks simpler, but makes the user know that "yield"
acts kinda onStuff, everything before yield is beforeStuff, and everything
after is afterStuff.
On the other hand, if we don't allow overriding the manager, we can hide the
walking logic, so I'm unsure what to choose. Ideas?

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list