[Libre-soc-bugs] [Bug 1094] insndb instruction database visitor-walker is needed

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu Jun 1 20:37:40 BST 2023


--- Comment #6 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Dmitry Selyutin from comment #5)
> I checked the visitor branch, and I have some thoughts to share.
> 1. If we take a 3rd-party code, please keep it as is. Yes this includes
> formatting. No need to adopt.

it's too big - normally i would agree. so i had to cut it back

> 2. I don't really like what I see in pyomo. It seems that the overall
> implementation is bloated, complex and too pyomo-way-centric

not surprising

> (unsurprisingly). This seems way more complex than it should've been.
> 3. The APIs you refer to (beforeChild, afterChild, etc.) are actually
> deprecated.

i didn't actually look closely! just "got it running"

> What I like, in contrast:
> 1. Something dead simple as html.parser visitors. Yes they are not as
> generic as pyomo, but there's no need to be generic in this exact case. We
> handle insns, not anything in the world.

i don't mind that at all.

> 2. The html.parser approach can be augmented with contextlib, like Jacob
> suggested. I have to check and play around the code, because I rarely used
> context managers before.


> Now on the order of the subtasks. I'd start with binutils.

because you know it well

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list