[Libre-soc-bugs] [Bug 1119] add byte reverse instructions in PowerISA v3.1B to ISACaller

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1119

--- Comment #5 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
jacob looks great: the patch to add the instruction is a good worked-example.
please do remember to keep to the project standard coding format.

* idx instead of really_long_unnecessary_variable_name
* "%s %d" % (mnemonic, idx) instead of PHP-style {mnemonic} {idx}
* x = y+5
  z = x*3
  instead of
  x = (y+5)*3 as a way to create *readable* code that does not
  hit the vertical-challenged-limitations of autopep8
* itertools.product() as a way to keep the indentation down.

everything in this patch is specifically targetted at getting the
indentation levels down.  the code is exactly the same number of lines:
one is readable (containing regular vertical alignment), the other is not.

readable ==> "easy to review" which is an extremely important part of
project maintenance, and your role is to make it easy for me to fulfil
*my* role.

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=d6b041c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.