[Libre-soc-bugs] [Bug 899] implement additional Transcendentals in simulator

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=899

--- Comment #37 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Dmitry Selyutin from comment #29)
> I followed Jacob's suggestion, except that I used insndb to generate
> binutils opcodes, as well as assembly and disassembly for tests. Please
> refer to the recent commits in dis branch. The result is
> sv_binutils_fptrans.py, which can be called with either opcodes or asm or
> dis argument;

brilliant.

>  these generate the needed files respectively. I have yet to
> check it with binutils, but the output looks reasonable on the first glance.
> 
> https://git.libre-soc.org/?p=openpower-isa.git;a=commit;
> h=ba64cb8d185380b854fdeb26cd1aeb07679dab96

ahh can we please not do this:

+        return f"{entry.name} {','.join(map(str, values))}"

i critically rely on colour syntax highlighting (left/right brain)
and PHP-style embedded programming within strings is far harder
to read and understand.

if you absolutely must use f"" which is itself confusing please
create a (short) temporary variable which is then inserted.

this is infinitely better as it separates the layout from
the variables/expressions being substituted and allows colour
syntax highlighting to reduce neural brain activity required to
identify

"%s %s" % (entry.name, ','.join(map(str, values)))

-- 
You are receiving this mail because:
You are on the CC list for the bug.