[Libre-soc-bugs] [Bug 519] Get output from ulx3s serial port to show up in minicom

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=519

--- Comment #13 from Cole Poirier <colepoirier at gmail.com> ---
Created attachment 111
  --> https://bugs.libre-soc.org/attachment.cgi?id=111&action=edit
Use OO instead of string testing in cofiguration

(In reply to Luke Kenneth Casson Leighton from comment #12)

> https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/litex/florent/
> versa_ecp5.py;hb=HEAD
> 
>   32             cpu_variant = "standardjtagnoirq",
> 
> check the ulx3s class, line 72.  see how duplication means the two
> near-identical classes get out of sync?

I have an idea of how this might be solved through using OO instead of strings.
See my attached patch. Is this a good approach? If not, why not? (I do
understand that the string testing in the other files will have to be changed
to work on the new classes instead, but I wanted your input on this before I do
all of that work)

[snip]
> you could have stopped around here (maybe a few more lines).
> 
> it showed success, the rest was effectively spam, because nobody is
> intwrested in the *contents* of the fact that picorv32 succeeded, just that
> it did in fact succeed.

Understood. Thanks for the guidance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.