[Libre-soc-bugs] [Bug 485] Create I-Cache from microwatt icache.vhdl

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=485

--- Comment #37 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #36)
> (In reply to Cole Poirier from comment #34)
> > (In reply to Luke Kenneth Casson Leighton from comment #32)
> > > req_hit_way is missing from icache_comb and at line 763 comb assign from
> > > req_hit also missing.
> > 
> > Pushed with link to this comment in commit message. I'm pretty sure I fixed
> > the first part, unsure about the second part, but I think I fixed it?
> 
> did you run it?  i can tell immediately just from looking at the code
> that you didn't.  why did you not run the code before committing?
> 
> remember: you need to think, logically, like a computer program, keeping
> a model of "expected python programs" in your head, and actually run them
> to make sure that you are constantly reminded of that.
> 
>   File "experiment/icache.py", line 768, in icache_comb
>     comb += req_hit_way.eq(hit_way)
> NameError: name 'req_hit_way' is not defined

No I didn't run it, you're right, I forgot. Sorry I've been really off this
week, will try harder :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.