[Libre-soc-bugs] [Bug 325] create POWER9 TRAP pipeline

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=325

--- Comment #131 from Samuel A. Falvo II <kc5tja at arrl.net> ---
(In reply to Luke Kenneth Casson Leighton from comment #127)
> this comment has been removed:
> 
> @@ -239,24 +211,6 @@ class Driver(Elaboratable):
>                  comb += [
>                      Assert(msr_o.ok),
>                      Assert(nia_o.ok),
> -                    ]
> -
> -                # Note: going through the spec pseudo-code, line-by-line,
> -                # in order, with these assertions.  idea is: compare
> -                # *directly* against the pseudo-code.  therefore, leave
> -                # numbering in (from pseudo-code) and add *comments* about
> -                # which field it is (3 == HV etc.)
> 
> its purpose is to explain why the strategy of how the code has been written
> was chosen.
> 
> removing it leaves people confused as to why the code is written the way
> that it is.
> 
> plus, a reviewer will think, "why is this code written in this fashion??
> it's so laborious, plenty of opportunities to quotes optimise quotes",
> not understanding that those optimisations *interfere* with clarity.

Sorry; it's hard for me to know which comments are for me-only versus general
consumption.  I'll put it back in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.