[libre-riscv-dev] [Bug 64] data handling / io control / data routing API needed

bugzilla-daemon at libre-riscv.org bugzilla-daemon at libre-riscv.org
Fri Apr 26 11:03:46 BST 2019


--- Comment #10 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #8)

> this will require every new class to actually derive from Data unless they
> want to implement the zillion functions themselves.

[more on this later, just want to make sure below isn't lost.  that
 "connect" function has been committed, and *one* of the uses of
 type() has been dealt with]

> Note that, last I checked, nmigen doesn't support using classes derived from
> Signal or Record since nmigen uses `type(a) is type(Signal)` instead of
> `isinstance(a, Signal)` in a lot of its code.

this is extremely bad practice that was warned about well over 10 years
ago (and since everyone listened and stopped doing it the advice stopped
being so well known).  i am... alarmed that they're disregarding standard
practices in this way by continuing to use it.

it's sufficiently important to ask, can you raise a bugreport on github
about it, and cross-reference here and also this:


You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-riscv-dev mailing list