[Libre-soc-dev] loadstore.py and dcbz modifications
Luke Kenneth Casson Leighton
lkcl at lkcl.net
Sun Oct 3 09:02:20 BST 2021
On Sun, Oct 3, 2021 at 8:23 AM Tobias Platen
<libre-soc at platen-software.de> wrote:
> I'm also joining the #libre-soc IRC channel now.
apologies, i meant to ask you, ages ago.
> > i have therefore disabled the set_dcbz_addr function and indicated
> > in comments what action needs to be taken in its place.
> When writing my unit tests, I first wanted to verify that dcbz is
> correct. I did not think about redundancies when writing set_dcbz_addr.
> > can you please remove it and adapt set_wr_addr by adding (at the end)
> > an extra dcbz parameter.
> I did, but not commited yet.
> > this will need to be done in *all six* places where set_wr_addr is
> > used.
> > please do all of them *in one single commit*, with an appropriate and
> > descriptive commit message.
> Just doing a grep shoud be fine, to find *all six* places.
i've a shellscript which helps with that, makes it easier, i'm sure there's
other ways too
find . -name "*.py" | xargs grep "$@"
> Bugreport will be created after doing the commit.
usually it's the other way round but hey :)
More information about the Libre-soc-dev