[Libre-soc-dev] loadstore.py and dcbz modifications
Luke Kenneth Casson Leighton
lkcl at lkcl.net
Sun Oct 3 00:45:44 BST 2021
https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=8f78d84e722d30efd553a5caa43ea2f96037ada6
tobias: i didn't see any messages on either the bugtracker or the mailing
list or the #libre-soc IRC channel about what exactly you planned to do
here.
if consulted, i would have said that it is better to add an extra dcbz parameter
to the set_wr_addr API rather than duplicate exact functionality of set_wr_addr
unnecessarily, across what is a key and fundamental part of the memory
infrastructure.
i have therefore disabled the set_dcbz_addr function and indicated
in comments what action needs to be taken in its place.
can you please remove it and adapt set_wr_addr by adding (at the end)
an extra dcbz parameter.
this will need to be done in *all six* places where set_wr_addr is used.
please do all of them *in one single commit*, with an appropriate and
descriptive commit message.
please also *document* that in an appropriate bugreport, and use the bugtracker
(as well as the mailing list) to communicate what you plan to do,
before you do it.
tia,
l.
---
crowd-funded eco-conscious hardware: https://www.crowdsupply.com/eoma68
More information about the Libre-soc-dev
mailing list