[Libre-soc-dev] daily kan-ban update 17may2021

[Jacob Lifshay]

On Tue, May 18, 2021, 02:47 Lauri Kasanen <cand at gmx.com> wrote:

> On Tue, 18 May 2021 12:40:53 +0300
> Lauri Kasanen <cand at gmx.com> wrote:
>
> > On Tue, 18 May 2021 02:31:13 -0700
> > Jacob Lifshay <programmerjake at gmail.com> wrote:
> >
> > > Trying the fp tests now. 33s for 10 tests (oof), they all failed with
> > > > AttributeError: _SimulatorState object has no attribute 'timeline'
> > > >
> > >
> > > iirc that's the message from us reaching into the nmigen simulator's
> > > internal state to get the elapsed simulated time and nmigen changed how
> > > they organize the simulator's internal state.
> > >
> > > Here's how I fixed that in the past:
> > >
> https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=e69d41220587c607be13a34cc14f917762dd529a;hp=1b165eb6465b426e6d64de2646d144d7fab5c2ea
> >
> > That fix doesn't work. Editing nmigen/nmigen/sim/pysim.py with
> > s/_state.timeline.now/_engine.now/ just causes the same AttributeError,
> > this time Simulator object has no attribute _engine.
>

The fix would be search/replace through our code, not nmigen.

nmigen rewrote their whole simulator, some simplistic text munging won't
work there.

>
> Well, I tracked that timeline belongs to SimulatorCore. SimulatorCore
> is passed as an input to the class of Simulator in pysim.py.
> I tried removing _state, but Simulator object has no attribute timeline.
>
> That's where my skills end. I have no idea how to access the passed
> SimulatorCore from Simulator.
>

If it's just a print call that needs `sim...now`, feel free to comment it
out or wrap in
try: ... except AttributeError: pass

>
> --
>
> BTW: it's painfully obvious all this is held together with bubblegum,
> not even tape, and barely runs even on the original devs' machines...
>

Yeah...symptoms of a serious lack of CI...

Jacob