[Libre-soc-bugs] [Bug 1066] fix bug where pseudo-code assignments modify more than just the variable being assigned to

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1066

Jacob Lifshay <programmerjake at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|IN_PROGRESS                 |RESOLVED

--- Comment #2 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #1)
> (In reply to Jacob Lifshay from comment #0)
> 
> > before this fix, that pseudo-code undesirably modified the value in the GPR!
> 
> that's why temporary variables are always used, with bit-ranges on
> them, so that the RHS becomes inherently a copy.

well, now that's unnecessary!
> 
>    a <- RA[0:XLEN-1]
> 
> can you please confirm that before committing this change you ran
> the *entire* test suite?

I did, before committing. you can also check ci, which passed:
https://salsa.debian.org/Kazan-team/mirrors/openpower-isa/-/commit/4e701a851536bba6648779c183293ba75e7ea7b8

-- 
You are receiving this mail because:
You are on the CC list for the bug.