[Libre-soc-bugs] [Bug 798] fix Ripple to use parallel prefix sum rather than a serial gate chain

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu May 5 05:27:06 BST 2022


https://bugs.libre-soc.org/show_bug.cgi?id=798

--- Comment #6 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #5)
> (In reply to Jacob Lifshay from comment #4)
> > Just noticed that both RippleLSB and RippleMSB set start_lsb=True, one of
> > them is wrong.
> 
> https://git.libre-soc.org/?p=nmutil.git;a=commitdiff;
> h=d5eb78c004feb45f660e47c34f2aa5203d0475f1
> 
> one of these...  MSB one should be False.

changed. RippleMSB is not used anywhere (at least couldn't find any other
mentions in all the git repos I have on my computer) and has no tests...

commit b5e82ab5d2012b9da8acf4d11169450d70ba4f2e (HEAD -> master, origin/master,
origin/HEAD)
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed May 4 21:24:08 2022 -0700

    fix RippleMSB

    TODO: add tests

    https://bugs.libre-soc.org/show_bug.cgi?id=798#c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list