[Libre-soc-bugs] [Bug 745] OP_TERNLOG instruction

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=745

--- Comment #60 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #59)
> (In reply to Luke Kenneth Casson Leighton from comment #58)
> > sorry jacob i moved OP_TERNLOG to its own
> > major op (to be chosen)
> 
> lets pick major 5 for now, since that means I have to change less rn.

ack.

> > good news is, Rc=1
> > is now possible. 
> 
> Ok, added Rc=1 to the code.
> 
> https://git.libre-soc.org/?p=openpower-isa.git;a=commit;
> h=79b540bb5d8f8ba139f56ff1e8010bde24df3d22

excellent.

> I also had to clean up where you accidentally used HTML comments instead of
> python comments in the pseudocode,

no, i did not make that mistake. HTML comments as long as they are on
one line are intentionally supported.


>  which caused compilation to fail
> (evidently you forgot to try compiling it...)

yes, i expected it to work.

> https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;
> h=4e181c8e868230e930292df33f9985c3bb78e30c

those comments aren't intended to go into the pseudocode,
they are as intended.  HTML-style comments *are* supported
(and desirable) and the parser should be fixed. can you
please revert that.

> Afaict this is complete now, Luke, can you allocate some budget to this and
> mark this bug resolved, so I can get paid soon?

that's down to michiel signing off the MoU.

-- 
You are receiving this mail because:
You are on the CC list for the bug.