[Libre-soc-bugs] [Bug 906] change HDL code to not use type annotations even for dataclasses

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=906

Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lkcl at lkcl.net

--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #3)
> I finished replacing dataclass in most the rest of the code (nmutil,
> nmigen-gf, and ieee754fpu), only place left is goldschmidt_div_sqrt.
> 
> I'm not replacing dataclass in nmigen, sby,

hell no, they're "outside the HDL remit" and i explained that the
strictness of dataclasses is strongly appropriate for formal correctness.

> or sv_binutils.py.

that's down to dmitry, the case for using dataclass there is...
[annoyingly-but-i-got-over-it] justifiable.  now that plain_data
exists it *might* be useable... 

> that covers everything I have checked out on my computer.

fantastic, thank you jacob.

-- 
You are receiving this mail because:
You are on the CC list for the bug.