[Libre-soc-bugs] [Bug 752] SPR FU broken with pspec.regreduce=True

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=752

Jacob Lifshay <programmerjake at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #2 from Jacob Lifshay <programmerjake at gmail.com> ---
I root-caused this issue, I added CommonPipeSpec.__getattr__ which caused the
SPR pipe to see pspec.regreduce == True where it hadn't ever before (cuz
regreduce wasn't ever copied to the FU pspecs).

This revealed a pre-existing bug in the SPR pipe where it tried to access CTR,
LR, etc. on SPRreduced, which until you just added them, didn't exist.

I found the bug by running:
cd openpower-isa
git checkout 455cc38127db6274d1902fb860d444618864da2a
make svanalysis && make pywriter && make pyfnwriter
cd ../soc
git checkout c672fb5eb93f1ab0040921496479188e08f90883
add breakpoint() at end of SPRMainStage.__init__
python src/soc/simple/test/test_issuer.py nosvp64 mul

notice that self.regreduce_en == False, even though, if you look further up the
call stack, you'll see that pspec.regreduce == True in TestRunnerBase.run_all

-- 
You are receiving this mail because:
You are on the CC list for the bug.