[Libre-soc-bugs] [Bug 324] create POWER DIV pipeline

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=324

--- Comment #38 from Jacob Lifshay <programmerjake at gmail.com> ---
argh, Chrome deleted all the text I was typing.

Anyway, it looks like a good start, though I don't know for sure as I'm not
familiar with the testing helper functions.

It needs some additional testing:
all the other div/mod instructions and their variants:
divdeo
divdeuo
divdo
divduo
divweo
divweuo
divwo
divwuo
modsd
modud
modsw
moduw

It needs some non-random test cases to hit the edge cases:
https://salsa.debian.org/Kazan-team/power-instruction-analyzer/-/blob/13dae100c6bc5685059195010ceb46ae68b9f306/src/main.rs#L210

soc.fu.div.setup_stage.DivSetupStage.elaborate was incorrectly changed:
https://git.libre-soc.org/?p=soc.git;a=commitdiff;h=8cc95f83fe437f4ac1eb5ebe57265bed30c0078c
...
-        # pass through op
+        # pass through core data

-        comb += self.o.op.eq(op)
+        comb += self.o.core.eq(core_o)

That should be op since op is used in the last div stage.
self.o.core.eq(core_o) is the same as self.o.core.eq(self.o.core), so is
useless.

-- 
You are receiving this mail because:
You are on the CC list for the bug.