[Libre-soc-bugs] [Bug 545] Some errors and failures when running tests, with recent nMigen

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=545

--- Comment #3 from Cesar Strauss <cestrauss at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #2)
> cesar please git pull and try again, madd had been added as a unit test and
> it does not exist.

Indeed, src/soc/fu/mul/test/test_pipe_caller.py now runs without problems.

> can you check first that it works under pysim?

To clarify, before running CXXSim, I ran all these tests under PySim, so that I
could detect any differences. So, all the results you see here were actually
made with PySim.

>> src/soc/fu/logical/test/test_pipe_caller.py

> if bpermd that is an ISACaller random fault

Yes, it seems to be the case.

>> 3) Tests that hangs (enters infinite loops):
>> src/soc/fu/compunits/test/test_logical_compunit.py 

> probably again because of bpermd

Maybe, I'm not sure. Merits investigating.

>> src/soc/simple/test/test_issuer.py

> if this is just the bpermd test that's fine

Again, I am not sure.

Here is the trace from test_issuer.py:

======================================================================
FAIL: run_all (__main__.TestRunner)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cstrauss/src/soc/src/soc/simple/test/test_issuer.py", line 311,
in run_all
    sim.run()
  File "/home/cstrauss/src/nmigen/nmigen/sim/core.py", line 168, in run
    while self.advance():
  File "/home/cstrauss/src/nmigen/nmigen/sim/core.py", line 159, in advance
    return self._engine.advance()
  File "/home/cstrauss/src/nmigen/nmigen/sim/pysim.py", line 272, in advance
    self._step()
  File "/home/cstrauss/src/nmigen/nmigen/sim/pysim.py", line 261, in _step
    process.run()
  File "/home/cstrauss/src/nmigen/nmigen/sim/_pycoro.py", line 123, in run
    self.coroutine.throw(exn)
  File "/home/cstrauss/src/nmigen/nmigen/sim/_pycoro.py", line 64, in run
    command = self.coroutine.send(response)
  File "/home/cstrauss/src/nmigen/nmigen/sim/core.py", line 93, in wrapper
    yield from process()
  File "/home/cstrauss/src/soc/src/soc/simple/test/test_issuer.py", line 259,
in process
    yield from sim.execute_one()
  File "/home/cstrauss/src/soc/src/soc/decoder/isa/caller.py", line 572, in
execute_one
    yield from self.call(opname)
  File "/home/cstrauss/src/soc/src/soc/decoder/isa/caller.py", line 723, in
call
    results = info.func(self, *inputs)
  File "/home/cstrauss/src/soc/src/soc/decoder/isa/caller.py", line 831, in
decorator
    result = func(*args, **kwargs)
  File "/home/cstrauss/src/soc/src/soc/decoder/isa/fixedlogical.py", line 310,
in op_bpermd
    perm[i] = RB[index]
  File "/home/cstrauss/src/soc/src/soc/decoder/selectable_int.py", line 275, in
__getitem__
    assert key < self.bits, "key %d accessing %d" % (key, self.bits)
AssertionError: key 128 accessing 64

----------------------------------------------------------------------
Ran 7 tests in 798.466s

FAILED (failures=1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.