[Libre-soc-bugs] [Bug 448] MUL pipeline unit tests

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=448

--- Comment #16 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #15)
> (In reply to Cole Poirier from comment #14)
> 
> > Makes sense, I commented it out and added a TODO. Unfortunately the test
> > fails like this. Should I commit?
> 
> you shouldn't be asking, it should have been done already: you should
> be *telling* me it's committed (2 days ago) within under 3 minutes.
> 
> 2 days of uncommitted work is a major "red flag" because during all
> that time absolutely nobody can look at it or comment on it.
> 
> the only reason i say this however is because unit tests are *SPECIFICALLY*
> isolated from all other tests and are consequently NOT on a critical code
> path that could prevent or prohibit anyone else from doing any work.

Thanks for the clarification. I'm still far too afraid of introducing things
that break things, so when I get errors I cower ;-)

Also, I committed the initial test where it failed due to madd* insns
yesterday. So only a half failure there :)

Committed and pushed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.