[Libre-soc-bugs] [Bug 449] FU unit tests checking output one cycle too late

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=449

Cole Poirier <colepoirier at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colepoirier at gmail.com

--- Comment #3 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #2)
> i ran test_div_compunit.py and it worked perfectly: i expected that it would.
> 
> with each test_pipe_caller.py being hand-written ready/valid signalling,
> it's kiinda "ok" that their ready/valid signalling is "borked" (or in
> the case of the single-stage ones such as ALU and Logical, *completely*
> borked).

Do you think in the future Managers for ready/valid signalling should be added
into the unit test? If so what is blocking this? Do the Managers need to be
formally verified first so we don't introduce an unrelated point of failure
into the DIV and MUL unit tests?

> as long as the test_*_compunit.py functions correctly it's fine.
> 
> this is precisely why we have unit tests at every integration level.
> 
> i think we're good on this one.

Or is it that these unit tests will be integrated into future higher-level unit
tests?

-- 
You are receiving this mail because:
You are on the CC list for the bug.