[Libre-soc-dev] No-op patch

Jacob Lifshay programmerjake at gmail.com
Mon Oct 5 00:52:40 BST 2020


While reading through the ISA simulator code, I noticed that
comparefixed.patch has a section not doing anything:
--- comparefixed.py.orig 2020-05-15 10:02:00.087668937 -0400
+++ comparefixed.py 2020-05-15 12:32:36.834556205 -0400
@@ -85,23 +85,22 @@
else:
in_range = le(src21lo, src1) & le(src1, src21hi) | le(src22lo, src1) & le(
src1, src22hi)
- CR[4 * BF + 32] = SelectableInt(value=0x0, bits=1)
- CR[4 * BF + 33] = in_range
- CR[4 * BF + 34] = SelectableInt(value=0x0, bits=1)
- CR[4 * BF + 35] = SelectableInt(value=0x0, bits=1)
+ CR[4 * BF + 32] = SelectableInt(value=0x0, bits=1)
+ CR[4 * BF + 33] = in_range
+ CR[4 * BF + 34] = SelectableInt(value=0x0, bits=1)
+ CR[4 * BF + 35] = SelectableInt(value=0x0, bits=1)

I did double check using diff, and the above changes don't actually
change anything.

Seems like we could regenerate that patch and it would probably be 2/3
as big, due to the above 8 lines being not necessary.

Jacob



More information about the Libre-soc-dev mailing list