[Libre-soc-bugs] [Bug 1177] revert unauthorized change to pseudocode language

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Mon Oct 2 00:52:07 BST 2023


https://bugs.libre-soc.org/show_bug.cgi?id=1177

--- Comment #2 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
https://git.libre-soc.org/?p=openpower-isa.git;a=blob;f=src/openpower/decoder/isa/caller.py;h=ce5a80a;hb=HEAD#l2197

2197         # get output named "overflow" and "CR0"
2198         overflow = outs.get('overflow')
2199         cr0 = outs.get('CR0')
2200         cr1 = outs.get('CR1')
2201 
2202         # soc test_pipe_caller tests don't have oe
2203         has_oe = hasattr(self.dec2.e.do, "oe")
2204         # yeah just no. not in parallel processing
2205         if has_oe and not self.is_svp64_mode:
2206             # detect if overflow was in return result

this dreadful-hack in ISACaller which spots if there is an output
variable called "overflow" keeps the pseudocode clean, and i have
absolutely no problem with it.  but it *will* need documenting
that that is what is going on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list