[Libre-soc-bugs] [Bug 1235] resolve openpower-isa repository screwups

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1235

Jacob Lifshay <programmerjake at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |IN_PROGRESS

--- Comment #2 from Jacob Lifshay <programmerjake at gmail.com> ---
the commit introducing the XLEN access:
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=5025354342d8e92f200b9c0c0a04f96a53d7f0e3

author  Luke Kenneth Casson Leighton <lkcl at lkcl.net>    
Tue, 28 Nov 2023 20:41:01 +0000 (20:41 +0000)
committer       Luke Kenneth Casson Leighton <lkcl at lkcl.net>    
Thu, 7 Dec 2023 17:52:56 +0000 (17:52 +0000)

so it was committed only a few days ago.

it looked like a trivial naming mistake to me, hence why I changed it to
self.XLEN

whoever was working on that branch that got committed to master by mistake
should have been looking at CI for that branch, if they had they should have
noticed that there were more failures than expected.

to prevent future mistaken pushes to master, luke maybe install a git hook that
requires confirmation before pushing to master?

this makes me think we need to enable CI report emails to everyone in Libre-SOC
-- they only get sent to the author and committer of the latest commit on the
branch being tested, all branches are independently tested in their own CI
runs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.