[Libre-soc-bugs] [Bug 1125] split instructions' pseudo-code into separate files so they can be [[!inline]]-ed into the wiki

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Tue Aug 1 14:40:56 BST 2023


https://bugs.libre-soc.org/show_bug.cgi?id=1125

--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #0)
> I changed the pseudo-code parser so it can parse [[!inline]] directives, and
> demoed changing one instruction (minmax. in av.mdwn),

ah sorry i wasn't clear enough: i meant the *entire* instruction.

not:

    # DRAFT Minimum/Maximum (Rc=1)

    MM-Form

    * minmax. RT,RA,RB,MMM (Rc=1)

    Pseudo-code:

    [[!inline pagenames="openpower/isa/av/minmax." raw="yes"]]

    Special Registers Altered:

        CR0                     (if Rc=1)

ACTUALLY have the ENTIRETY of the instruction (all of the above)
in minmax..mdwn

such that av.mdwn becomes:

<!-- DRAFT Instructions for PowerISA Version 3.0 B Book 1 -->
<!-- https://libre-soc.org/openpower/sv/bitmanip/ -->
<!-- https://libre-soc.org/openpower/sv/av_opcodes/ -->
[[!inline pagenames="openpower/isa/av/minmax." raw="yes"]]
[[!inline pagenames="openpower/isa/av/other" raw="yes"]]
[[!inline pagenames="openpower/isa/av/next" raw="yes"]]

the way that you chose to do it was a lot more work, wasn't it?

all you actually had to do by doing the entire instruction
was look for "#" in the split-insns.sh file then add a second
level of subdirectories, or read "av.mdwn" for example and
notice "av/minmax" in it.

that's about... 15-20 minutes of work.

what you are proposing requires far more work as it involves
massive intrusive changes to the instruction parser.

which we DO NOT have time for and i do not want time or money
wasted on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list