[Libre-soc-bugs] [Bug 545] Some errors and failures when running tests, with recent nMigen

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=545

--- Comment #9 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Cesar Strauss from comment #7)
> (In reply to Luke Kenneth Casson Leighton from comment #1)
> > > src/soc/fu/logical/test/test_pipe_caller.py
> > 
> > if bpermd that is an ISACaller random fault 
>   
> > if you re-run the logical tests multiple times they *should* succeed because
> > ISACaller receives random values that do not trigger its bug.
> 
> It took me 11 attempts to get a success, but I finally got it.

i finally fixed the pseudo-code, it was an 8 bit number that should
be treated as unsigned: when the value read was 128 or greater it was
being considered negative.


index 99d5505..c574911 100644
--- a/openpower/isa/fixedlogical.mdwn
+++ b/openpower/isa/fixedlogical.mdwn
@@ -468,7 +468,7 @@ Pseudo-code:
     perm <- [0] * 8
     for i = 0 to 7
        index <- (RS)[8*i:8*i+7]
-       if index < 64 then
+       if index <u 64 then
             perm[i] <- (RB)[index]
        else
             perm[i] <- 0

-- 
You are receiving this mail because:
You are on the CC list for the bug.