[Libre-soc-bugs] [Bug 607] unnecessary code added related to MMU in PowerDecoder2

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Mon Mar 1 19:41:14 GMT 2021


--- Comment #5 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Tobias Platen from comment #4)
> In src/soc/simple/core.py I added this line:          
> self.decoders["mmu0"].mmu0_spr_dec = self.decoders["spr0"] 

ok that will need a comment, cross-reference this bugreport as well
special-case hacks like that we need to pay attention to.  then also
cross-reference it in PowerDecoderSubset as well, that mmu_spr_dec
is set up in simple/core.py

what we don't need is surprises when people go "where does mmu0_spr_dec
come from, it's not in the constructor, wtf??"

> after having found out using GTKWave that the insn_type for mmu0 is
> OP_INVALID in my unit test where is use "mtspr 18, 1". The correct insn_type
> for DSISR DAR SVSRR0 and PIDR is passed to the wrong function unit instead.

yyeah this is because of the subset decoding. there may be more that needs
doing, here.

note i've just pushed this:

commit f5549bf43d740610a5980b5930241ff37641bdd6 (HEAD -> master, origin/master)
Author: Luke Kenneth Casson Leighton <lkcl at lkcl.net>
Date:   Mon Mar 1 19:35:31 2021 +0000

    Revert "fix Bug 607 - unnecessary code added related to MMU in

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list