[Libre-soc-bugs] [Bug 441] Avoid unit tests that depend on other unit tests being run first

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=441

Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lkcl at lkcl.net

--- Comment #10 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #9)
> working on cleaning up more tests.
> 
> Luke, does what I changed so far look good?

yeah i like it.

btw one thing you may have noticed i did in.. oh! you move it to
DivTestHelper() :)

the levels of indentation particularly when adding subTest() were
far too great.

commit e51ea2436a790173017d2c7766b54c097dd89a9b (HEAD -> master)
Author: Luke Kenneth Casson Leighton <lkcl at lkcl.net>
Date:   Wed Jul 29 11:49:16 2020 +0100

    move actual ALU test out of subTest indentation just like for div

i've done ALU, DIV, and one other like this, now.  it means less pressure
on indentation and, also interestingly, identifies code that really should
be put into a base class (what's left of run_all / run_it).

-- 
You are receiving this mail because:
You are on the CC list for the bug.