[Libre-soc-bugs] [Bug 325] create POWER9 TRAP pipeline

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Fri Jul 24 15:43:24 BST 2020


--- Comment #135 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Samuel A. Falvo II from comment #132)
> (In reply to Luke Kenneth Casson Leighton from comment #126)
> > 1) comments are added which "explain why".  removing comments is detrimental
> >    to communication and code maintenance.
> My aim was to remove only those comments I felt were addressed solely to me.
> I wasn't clear which comments qualified.

yehyeh, my fault. i've added XXX at start and end of bits that can be removed,

> >    now where field_slice is used 30, 31 you've *introduced* a bug)
> Actually, removed one.  ;)  Walk through the code again.  :)  That's why I
> wrote the function: to automate the error-checking, so that I wouldn't run
> into this issue again.

good idea.  even as a tiny function it is still critically important to
properly comment and document, because of the massive confusion and interaction
with python slices.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list