[Libre-soc-bugs] [Bug 176] partitioned dynamic bool/all/any/xor operators

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Mon Dec 28 13:38:35 GMT 2020


https://bugs.libre-soc.org/show_bug.cgi?id=176

--- Comment #8 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to ps905 from comment #7)

> >  def any(self):
> >     return self == Const(-1)
>  
> >would you like to try writing the (two lines!) some() case?
> 
> sure will do this

cool.  i just committed this:

commit cc37b3eed710bc3d8877b6170dcb0d6da183eea2 (HEAD -> master)
Author: Luke Kenneth Casson Leighton <lkcl at lkcl.net>
Date:   Mon Dec 28 13:34:49 2020 +0000

    partsig: redirect bool to any for now, and use a == Const(-1) for any

so if you can do the same, ahh sorry, that one was for "all()" not "any()"
(doh)

if you can do any() using the != and, just like i did, make sure to add a
comment in both the code and in the commit message (do not exceed 80 char
line lengths in either case)

just commit it: don't worry about writing unit tests (etc) yet, thsis code is
unused at the moment so there is no "damage" that you can do.  this will get
you familiar with the "commit" process.  i'll do a review after.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list