[Libre-soc-bugs] [Bug 450] Create MMU from microwatt mmu.vhdl

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=450

--- Comment #57 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #55)
>  719 #               mbits := '0' & r.mask_size;
>  720 #               v.shift := r.shift + (31 - 12) - mbits;
>  721 #               nonzero := or(r.addr(61 downto 31) and
>  722 #                           not finalmask(30 downto 0));
> 
> you can't assign to nonexistent variables.
> 
> mbits = Signal(r.mask_size.width+1)
> nonzero = Signal()
> 
> put those lines just before they are used.
> 
> do not add "self." in front of them.  they are local not members of the
> class.

They actually are members of the class, declared here:

```
348         self.mbits = Signal(6)
349         self.pgtable_addr = Signal(64)
350         self.pte = Signal(64)
351         self.tlb_data = Signal(64)
352         self.nonzero = Signal()

385         mbits = self.mbits
386         pgtable_addr = self.pgtable_addr
387         pte = self.pte
388         tlb_data = self.tlb_data
389         nonzero = self.nonzero
```

Should I still make the fix you've suggested in this comment?

-- 
You are receiving this mail because:
You are on the CC list for the bug.