[Libre-soc-bugs] [Bug 448] MUL pipeline unit tests

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=448

--- Comment #39 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Cole Poirier from comment #38)

>  Just committed a new version, please provide further feedback :)

i would be able to do so if you had done "git push"...

> > you would have seen every single instruction had rb=0, which is not the
> > intent, is it?
> 
> Agreed, I just didn't understand it sufficiently to be able to do this, but
> these comments bring me closer to understanding. This was my intention.
> Commit what I understood I should do, and wait for better understanding to
> come through your corrections.

now all we need to do is have _you_ think through the implications of what
you're doing rather than asking me to do it!

there are two absolutely crucial aspects to team programming:

1) communication - constant feedback and discussion
2) modelling and debugging: feedback on the *code*.

the first of these you're doing extremely well.  the latter you've not yet got
the idea that *you* need to think through, from words/thoughts and abstract
design concepts, translating that into step-by-step code.

the expectation is therefore in this case that *each* instruction will need
testing with a series of random values targetting the overflow range.  that
therefore implies a *two* level nested for-loop:

outer loop: instruction
inner loop: 20 (or so)
execution: *NOW* we create random values targetting close to the overflow
range.

-- 
You are receiving this mail because:
You are on the CC list for the bug.