[Libre-soc-isa] [Bug 1052] OPF RFC ls012 writeup: list of RFCs to be proposed to OPF ISA WG

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1052

--- Comment #4 from Andrey Miroshnikov <andrey at technepisteme.xyz> ---
(In reply to Luke Kenneth Casson Leighton from comment #3)
> mm.  any suggestions?
> 
> how about
> 
> `xxeval`.  The same reasoning applies as to fclass: SFFS needs to be
> stand-alone on its own merits and should an implementor
> choose not to implement any aspect of PackedSIMD VSX the performance
> of their product should not be penalised for making that decision.

Sounds really good!

> 
> > 
> > In the Tables section (page 4), "mutually exclusively" doesn't sound right
> > to me.
> 
> it's a mathematical term, english language for the XOR operation.
> https://www.merriam-webster.com/dictionary/mutually%20exclusive

I've heard of "mutually exclusive", but it's the second "-ly" ending that threw
me off. Initially sounded wrong, but now re-reading I realise that
"exclusively" would modify "incompatible".

>  
> > 
> > Initially I couldn't find the explanation for the "cost" column, but then
> > realised the description calls it "XO Cost". I suggest the actual table
> > column is also called "XO Cost" to reduce ambiguity.
> 
> can you add a dictionary lookup-column-heading-replacement function?
> i want to keep the csv file headings short to fit into below 80 chars
> use "lookupdict.get(heading, heading)" as it returns the word itself
> if there is no entry. neat trick.
> 
> (edit: ls012_optables.py)

Yes, added a function to do that. Just need to call it at the right place
(needs to happen after sorting, otherwise will get errors about 'cost' not
being found).

https://git.libre-soc.org/?p=libreriscv.git;a=commitdiff;h=8b670c6696e9eb0b2fae2a2e3ae643d6dda48956

> 
> > 
> > Another issue I found is that entries under PO1 column are "??" for LD/ST
> > Post Increment, though that might be a problem with the pdf generation.
> 
> no look at the row, they are "TODO".

The csv file also uses "??" for TODO entries, so looks like my local pdf
generation is working.
https://git.libre-soc.org/?p=libreriscv.git;a=blob;f=openpower/sv/rfc/ls012/optable.csv;h=833dd9e9869d735a8b47c8e5fc7198a45777af63;hb=HEAD

-- 
You are receiving this mail because:
You are on the CC list for the bug.