[Libre-soc-isa] [Bug 896] DOUBLE2SINGLE doesn't handle generating the return value for inf/nan inputs

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=896

Jacob Lifshay <programmerjake at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CONFIRMED
         Resolution|INVALID                     |---

--- Comment #2 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #1)
> (In reply to Jacob Lifshay from comment #0)
> > the if branches seem to have been forgotten
> > 
> > https://git.libre-soc.org/?p=openpower-isa.git;a=blob;f=openpower/
> > isafunctions/double2single.mdwn;
> > hb=5f111b1fb9285c3605d0062bb41b50ac7fea550c#l42
> 
> no they haven't, look at it more closely.  goto does not
> exist in the syntax (it was not a keyword in section 1.3(?).
> 
> i therefore created an intermediate variable "mode" as a
> substitute.

yeah I guessed that. you missed my point:

when `mode` is set to 'inf_operand', nothing later checks if `mode` is
'inf_operand' and changes `result`, so `result` is left set to 0, which is the
wrong answer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.