[Libre-soc-isa] [Bug 686] create Power ISA test API

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Fri Sep 10 22:14:50 BST 2021


https://bugs.libre-soc.org/show_bug.cgi?id=686

--- Comment #31 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to klehman9 from comment #30)
> https://git.libre-soc.org/?p=soc.git;a=commit;
> h=06b8931eb167030bc47a287424ce4b9cadd854ce
> 
> Hopefully this is what you were looking in regards to the base class.

pretty much, yeah!  creating the functions with "pass" in them is
unnecessary btw, one of the weirdities of python, you can have "APIs
as conventions" and follow the Liskov Substitution Principle rather
than have explicit functions.

> Has no effect on unmodified test caller, svp passes.  Svp passes when
> changes are made to utilize new get_state method.

great! getting there.  so what do you think of the
idea of adding the check_regs functions to the new
class?

or, do you think it would be better to have a global
function in teststate.py which takes:

1) dut parameter
2) test fn name parameter
3) code parameter
4) *list* of state(s) to compare

where it would test el0 against el1, el1 against el2, el2
against el3 .... 

or... both?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Libre-SOC-ISA mailing list