[Libre-soc-isa] [Bug 686] create Power ISA test API

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=686

--- Comment #29 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to klehman9 from comment #28)
> Spacing noted.
> 
> Naming - Yeah, something like that.  I'll keep the potential naming thing
> all in mind for the future.  Definitely fine as is for the moment.

ok cool.  test_issuer.py passes btw so nothing broken, a good sign.

what's next...

the next code-morph would be one that reduces the amount of explicit
function calls and those that are identical.

i.e.:

* group all sim.get_xxx() together
* group all hdl.get_xxx() together
* make a base class containing a function that calls self.get_xxx()

and work towards a function (which check_regs would call) that
takes:

* a dut
* a dictionary {'sim': sim, 'hdl': core}
* anything else

and does a lookup in a "Factory" dict:

klsfactory = {'sim': SimState, 'hdl': HDLState }

gets the class to create, passing sim or core in.

you get the general idea

-- 
You are receiving this mail because:
You are on the CC list for the bug.