[Libre-soc-isa] [Bug 685] Implement XLEN-ification for BCD instructions in base OpenPower ISA

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=685

--- Comment #3 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #2)
> (In reply to Jacob Lifshay from comment #1)
> > the old test suite didn't support checking if invalid BCD inputs converted
> > correctly.
> 
> The old test suite uses reference code based on matching against a table
> that goes from 000 to 999, so the reference code will fail if the input is
> something like 0xA7E since that isn't in the table. Pia uses the boolean
> expressions from the OpenPower spec, so can handle all binary input values.

just going through things.

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=338e538b7148554adb64025ac6cfe8e274f6d8c4

looks good.

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=096b8d60b6500ec8af98c2442ebb0f31066b0bcb

this depends on pia.  as i explained, pia has to go, therefore
adding more dependence on it means more work down the line to
do.

can you please therefore remove the dependence on pia.

it doesn't matter if it's more "work".  whatever is in pia
needs to be rewritten in pure python, to make it long-term
portable with no high-maintenance-cost "surprises", and be
something that 30% of the world's programmers can work on

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=59c0e03a15e3c62603e91e23ac775de42a05d8e7

eurr! intriguing :)

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=d05da12e8e726e2de36ff468158a1371ba9ab917

looks waaay better. the general practice in the Power ISA document is to
use (obscure and) short variable names. i'm sure they'll get over
the use of meaningful ones.

i'll re-run test_caller_bcd.py to make sure it passes (with the new
XLEN-based pseudo-code).

test_caller_bcd_long.py i will wait until the dependence on pia has
been removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.