[Libre-soc-dev] daily kan-ban update 05dec2021

[Tobias Platen]

On Sun, 2021-12-05 at 11:05 +0000, Luke Kenneth Casson Leighton wrote:
> On Sun, Dec 5, 2021 at 8:54 AM Tobias Platen
> <libre-soc at platen-software.de> wrote:
> > 
> > this morning: having a look at the recent changes
> 
> it's generally bad practice to have a dozen identical copies of a
> function.
> what happens - actually happened - is that *two* of those copies were
> modified so that they were completely different and had the exact
> same
> name.
> 
> i had created a canonical version for you to use but you did not use
> it.
> instead, you copied an older version that was different.
> 
> i therefore spent about an hour late last night removing the copies.
> which of course meant that that was an hour *not* doing useful work
> 
> please do try not to do that again.
I won't try to do that again, I know that this is bad practice.
> 
> regarding the actual work - which was delayed by cleaning up - i
> am checking that using wb_get is possible by passing in a
> "rom" argument to TestIssuer.  this should make it possible to
> use the exact same virtual memory data structures (as a dictionary)
> that were used for the low-level tests.
That might be a good idea, at least for the pagetables as they usually
do not change in our tests. I will have a deeper look at TestIssuer
now.
> 
> l.
> 
> _______________________________________________
> Libre-soc-dev mailing list
> Libre-soc-dev at lists.libre-soc.org
> http://lists.libre-soc.org/mailman/listinfo/libre-soc-dev